Skip to content

update go to 1.26.1#56

Merged
ske-prow[bot] merged 1 commit intomainfrom
update-go
Mar 24, 2026
Merged

update go to 1.26.1#56
ske-prow[bot] merged 1 commit intomainfrom
update-go

Conversation

@breuerfelix
Copy link
Copy Markdown
Member

@breuerfelix breuerfelix commented Mar 18, 2026

How to categorize this PR?

/kind technical-debt

What this PR does / why we need it:
Updates to go 1.26.1 with its latest language features

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow bot added kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2026
@breuerfelix
Copy link
Copy Markdown
Member Author

breuerfelix commented Mar 18, 2026

/hold until tested

@ske-prow ske-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2026
@breuerfelix
Copy link
Copy Markdown
Member Author

breuerfelix commented Mar 18, 2026

image tested in ondemand with openstack and stackit shoot

@breuerfelix
Copy link
Copy Markdown
Member Author

breuerfelix commented Mar 18, 2026

/unhold

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2026
@breuerfelix breuerfelix requested a review from a team March 18, 2026 15:50
nschad
nschad reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like everywhere we use ptr.To instead of Go 1.26 new. Should we really change that? We also use ptr.Deref in some cases

Personally new is also kinda confusing to me, new what? 🤷

Is that new recommendation coming from the golangci-lint modernize plugin?

@breuerfelix
Copy link
Copy Markdown
Member Author

breuerfelix commented Mar 19, 2026

I feel like everywhere we use ptr.To instead of Go 1.26 new. Should we really change that? We also use ptr.Deref in some cases

Personally new is also kinda confusing to me, new what? 🤷

Is that new recommendation coming from the golangci-lint modernize plugin?

Everything changed were just recommendations by modernize and even though new reads a little weird in these use cases, it does what it used to do in other languages as well. It creates a new 'object' and returns the pointer to it.
In general in would not argue about that. It is a language feature that deprecates other libraries so we should use it.
Also the ptr.Deref is something we should still keep because we do not use it for dereferencing but rather as a defaulting function. Otherwise we could have just used & :D

@breuerfelix
Copy link
Copy Markdown
Member Author

breuerfelix commented Mar 23, 2026

/retest

@ske-prow ske-prow bot assigned xoxys Mar 24, 2026
@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow bot commented Mar 24, 2026

LGTM label has been added.

DetailsGit tree hash: 0d04de9d4a02c59d90fcd1bd3aba30b795345394

@ske-prow ske-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 24, 2026
@breuerfelix
update go to 1.26.1
1d459f9 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@ske-prow ske-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@ske-prow ske-prow bot requested a review from xoxys March 24, 2026 14:41
@ske-prow ske-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2026
@breuerfelix
Copy link
Copy Markdown
Member Author

breuerfelix commented Mar 24, 2026

/retest

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow bot commented Mar 24, 2026

LGTM label has been added.

DetailsGit tree hash: 7c3a487c7e069adc483f03cb1d65eec73bd5af63

@ske-prow
Copy link
Copy Markdown

ske-prow bot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xoxys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot merged commit d8690fc into main Mar 24, 2026
4 checks passed
@ske-prow ske-prow bot deleted the update-go branch March 24, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad left review comments

@xoxys xoxys xoxys approved these changes

Assignees

@xoxys xoxys

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@breuerfelix @xoxys @nschad